Skip to content

Conversation

@picnixz
Copy link
Member

No description provided.

@picnixz
Copy link
MemberAuthor

I don't know why the SBOM regeneration fails on Windows (looks like a network issue) :') Guess I'll just try again a bit later.

@AA-Turner
Copy link
Member

It is wasteful to run CI on updates to CODEOWNERS, perhaps we should add it to the exclusions here:

if [ -z "$GITHUB_BASE_REF" ]; then
echo "run-tests=true" >> "$GITHUB_OUTPUT"
else
git fetch origin "$GITHUB_BASE_REF" --depth=1
# git diff "origin/$GITHUB_BASE_REF..." (3 dots) may be more
# reliable than git diff "origin/$GITHUB_BASE_REF.." (2 dots),
# but it requires to download more commits (this job uses
# "git fetch --depth=1").
#
# git diff "origin/$GITHUB_BASE_REF..." (3 dots) works with Git
# 2.26, but Git 2.28 is stricter and fails with "no merge base".
#
# git diff "origin/$GITHUB_BASE_REF.." (2 dots) should be enough on
# GitHub, since GitHub starts by merging origin/$GITHUB_BASE_REF
# into the PR branch anyway.
#
# https://github.com/python/core-workflow/issues/373
git diff --name-only "origin/$GITHUB_BASE_REF.." | grep -qvE '(\.rst$|^Doc|^Misc|^\.pre-commit-config\.yaml$|\.ruff\.toml$|\.md$|mypy\.ini$)' && echo "run-tests=true" >> "$GITHUB_OUTPUT" || true
fi

A

@picnixz
Copy link
MemberAuthor

I'll wait for #128754 to be merged so that we can test it (I'll make an empty commit to trigger the CI).

@picnixzpicnixz changed the title Add @picnixz to cryptographic primitives code owners.Add @picnixz and @gpshead to cryptographic primitives code owners.Jan 13, 2025
@picnixzpicnixz changed the title Add @picnixz and @gpshead to cryptographic primitives code owners.Update cryptographic primitives code owners.Jan 13, 2025
@hugovk
Copy link
Member

I'll wait for #128754 to be merged so that we can test it (I'll make an empty commit to trigger the CI).

Now merged.

@picnixz
Copy link
MemberAuthor

picnixz commented Jan 14, 2025

It looks like the CI is now in a good shape:

image

I guess we're good to go then.

@hugovkhugovk merged commit eefd4a0 into python:mainJan 14, 2025
23 checks passed
@picnixzpicnixz deleted the picnixz-codeowners branch January 14, 2025 09:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@picnixz@AA-Turner@hugovk@gpshead