Skip to content

gh-128911: Add PyImport_ImportModuleAttr() function#128912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 11 commits into from
Jan 30, 2025
Merged

gh-128911: Add PyImport_ImportModuleAttr() function #128912

vstinner merged 11 commits into from
Jan 30, 2025

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Jan 16, 2025•
edited by github-actions bot
Loading

Remove "pycore_import.h" includes, no longer needed.

📚 Documentation preview 📚: https://cpython-previews--128912.org.readthedocs.build/

@vstinner
pythongh-128911: Add PyImport_GetModuleAttrString() function
5f320d1
Remove "pycore_import.h" includes, no longer needed.
@bedevere-appbedevere-appbot mentioned this pull request Jan 16, 2025
Closed
@vstinner
Copy link
MemberAuthor

vstinner commented Jan 16, 2025•
edited
Loading

TODO: Write tests. But PyImport C API is currently not tested, we need maybe to first write tests for existing functions?

vstinner added a commit to vstinner/cpython that referenced this pull request Jan 16, 2025
@vstinner
pythongh-128912: Add tests on the PyImport C API
3a83056
* Add Modules/_testlimitedcapi/import.c * Add Lib/test/test_capi/test_import.py
@vstinner
Copy link
MemberAuthor

vstinner commented Jan 16, 2025

But PyImport C API is currently not tested, we need maybe to first write tests for existing functions?

I wrote #128915 to add these tests first.

@vstinnervstinner mentioned this pull request Jan 17, 2025
Merged
@vstinnervstinner requested a review from a team as a code ownerJanuary 17, 2025 21:17
@vstinner
Copy link
MemberAuthor

vstinner commented Jan 17, 2025

TODO: Write tests.

Done, I added tests.

corona10
corona10 reviewed Jan 19, 2025
View reviewed changes
corona10
corona10 approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@vstinnervstinner mentioned this pull request Jan 19, 2025
Closed
6 tasks
@vstinner
Copy link
MemberAuthor

vstinner commented Jan 19, 2025

I created a C API Working Group decision issue: capi-workgroup/decisions#53

serhiy-storchaka
serhiy-storchaka reviewed Jan 26, 2025
View reviewed changes
Lib/test/test_capi/test_import.py Outdated
# CRASHES execute_code_func(name, NULL, NULL, NULL)

def check_getmoduleattr(self, getmoduleattr):
self.assertIs(getmoduleattr('sys', 'argv'), sys.argv)
Copy link
Member

@serhiy-storchakaserhiy-storchakaJan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check also a module name containing dots.

Check errors:

  • non-existent module
  • relative module name
  • non-existent attribute
  • attribute name containing dots

Copy link
MemberAuthor

@vstinnervstinnerJan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added requested tests.

attribute name containing dots

getmoduleattr('sys', 'implementation.name') raises an AttributeError. I prefer to not implement "nested" getattr(). One should write getmoduleattr('sys', 'implementation') + PyObject_GetAttrString(attr, "name").

@vstinner
Copy link
MemberAuthor

vstinner commented Jan 26, 2025

I renamed the function to PyImport_ImportModuleAttr().

@vstinnervstinner changed the title gh-128911: Add PyImport_GetModuleAttrString() functiongh-128911: Add PyImport_ImportModuleAttr() functionJan 26, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@vstinner
Copy link
MemberAuthor

vstinner commented Jan 29, 2025

I created a C API Working Group decision issue: capi-workgroup/decisions#53

The C API Working Group approved the PyImport_ImportModuleAttr() API.

@vstinnervstinner enabled auto-merge (squash) January 30, 2025 11:12
@vstinnervstinner merged commit 3bebe46 into python:mainJan 30, 2025
41 checks passed
@vstinnervstinner deleted the import_getattr branch January 30, 2025 11:17
@vstinner
Copy link
MemberAuthor

vstinner commented Jan 30, 2025

Merged, thanks for reviews!

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@vstinner@srinivasreddy
pythongh-128911: Add PyImport_ImportModuleAttr() function (python#128912
2721adc
) Add PyImport_ImportModuleAttr() and PyImport_ImportModuleAttrString() functions. * Add unit tests. * Replace _PyImport_GetModuleAttr() with PyImport_ImportModuleAttr(). * Replace _PyImport_GetModuleAttrString() with PyImport_ImportModuleAttrString(). * Remove "pycore_import.h" includes, no longer needed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@corona10corona10corona10 approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@serhiy-storchaka@corona10@erlend-aasland