gh-128978: Fix a NameError in sysconfig.expand_makefile_vars#128979
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
picnixz added needs backport to 3.13 
Uh oh!
There was an error while loading. Please reload this page.
picnixz merged commit df66ff1 into python:main 40 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
pythonGH-128979) This fixes a regression introduced by 4a53a39. (cherry picked from commit df66ff1) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
pythonGH-128979) This fixes a regression introduced by 4a53a39. (cherry picked from commit df66ff1) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-129065 is a backport of this pull request to the 3.13 branch. |
GH-129066 is a backport of this pull request to the 3.12 branch. |
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
python#128979) This fixes a regression introduced by 4a53a39.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sysconfig.expand_makefile_vars#128978