Skip to content

Improve tests for _colorize.can_colorize()#129234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 5 commits into from
Jan 24, 2025
Merged

Improve tests for _colorize.can_colorize() #129234

hugovk merged 5 commits into from
Jan 24, 2025

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Jan 23, 2025

No description provided.

@serhiy-storchakaserhiy-storchaka added tests Tests in the Lib/test dir skip issue needs backport to 3.13 bugs and security fixes labels Jan 23, 2025
@serhiy-storchakaserhiy-storchaka mentioned this pull request Jan 23, 2025
Merged
@serhiy-storchakaserhiy-storchaka marked this pull request as ready for review January 23, 2025 18:24
hugovk
hugovk approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

Lib/test/test__colorize.py
importunittest
importunittest.mock
import_colorize
fromtest.supportimportforce_not_colorized, make_clean_env
Copy link
Member

@hugovkhugovkJan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make_clean_env was moved to test.support from the PyREPL tests for use in this file (in #127877).

If we're not using it here any more, should we move it back, or leave it in case it's useful for others later?

Copy link
MemberAuthor

@serhiy-storchakaserhiy-storchakaJan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know. I tried to use make_clean_env(), but we need to remove also NO_COLOR. On other hand, the only PYTHON* variable that needs to be removed is PYTHON_COLORS. Let it be there for now, and then we'll see.

@serhiy-storchaka@hugovk
Update Lib/test/test__colorize.py
5c2c829
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovkhugovk merged commit 7907203 into python:mainJan 24, 2025
37 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented Jan 24, 2025

Thanks @serhiy-storchaka for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@hugovk
Copy link
Member

hugovk commented Jan 24, 2025

Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2025
@serhiy-storchaka@hugovk@miss-islington
Improve tests for _colorize.can_colorize() (pythonGH-129234)
2993cfe
(cherry picked from commit 7907203) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-appbot commented Jan 24, 2025

GH-129265 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jan 24, 2025
serhiy-storchaka added a commit that referenced this pull request Jan 24, 2025
@miss-islington@serhiy-storchaka@hugovk
[3.13] Improve tests for _colorize.can_colorize() (GH-129234) (GH-129265
e07a6fe
) (cherry picked from commit 7907203) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

skip issueskip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka@hugovk