gh-119182: Use public PyUnicodeWriter in _json.c#129249
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API.
cmaloney approved these changes Jan 24, 2025
Contributor
cmaloney left a comment
cmaloney left a comment There was a problem hiding this comment.
Have a plan for _PyUnicodeWriter_IsEmpty?
MemberAuthor
vstinner commented Jan 24, 2025
My plan is to leave it in Also, the function can be removed and replaced with an |
vstinner merged commit 6e63c47 into python:main 44 checks passed
Uh oh!
There was an error while loading. Please reload this page.
25 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API.