Skip to content

gh-102471: Change PyLongWriter_Discard(NULL) to do nothing#129339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Jan 27, 2025
Merged

gh-102471: Change PyLongWriter_Discard(NULL) to do nothing #129339

vstinner merged 1 commit into from
Jan 27, 2025

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Jan 27, 2025•
edited by github-actions bot
Loading

It's convenient to be able to call PyLongWriter_Discard(NULL) in error handling code.

📚 Documentation preview 📚: https://cpython-previews--129339.org.readthedocs.build/

@vstinner
pythongh-102471: Change PyLongWriter_Discard(NULL) to do nothing
e3ed89b
It's convenient to be able to call PyLongWriter_Discard(NULL) in error handling code.
@bedevere-appbedevere-appbot mentioned this pull request Jan 27, 2025
Open
@vstinner
Copy link
MemberAuthor

vstinner commented Jan 27, 2025

cc @skirpichev

Make PyLongWriter_Discard(NULL) similar to PyUnicodeWriter_Discard(NULL): do nothing.

@vstinnervstinner enabled auto-merge (squash) January 27, 2025 10:44
@vstinnervstinner merged commit 7ec1742 into python:mainJan 27, 2025
46 checks passed
@vstinnervstinner deleted the long_discard branch January 27, 2025 10:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichevskirpichevskirpichev approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@skirpichev