gh-129205: Update multiprocessing.forkserver to use os.readinto#129425
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
6 tasks
vstinner approved these changes Jan 30, 2025
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM, I just suggest to remove the NEWS entry.
| @@ -0,0 +1,2 @@ | |||
| :mod:`multiprocessing` forkserver now uses :func:`os.readinto` to read pid | |||
Member
There was a problem hiding this comment.
I don't think that it's worth it to document this change to end users. I suggest to remove this NEWS entry.
vstinner merged commit 10ee2d9 into python:main 40 checks passed
Uh oh!
There was an error while loading. Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a single pre-allocated bytearray for temporary storage,
os.readintoit avoiding non-mutable bytes.