CI: Change job name to 'build arm64' on Windows#129434
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hugovk added needs backport to 3.12 
Eclips4 approved these changes Jan 29, 2025
Member
Eclips4 left a comment
Eclips4 left a comment There was a problem hiding this comment.
LGTM. Thanks! Though maybe it makes sense to add a small comment to the code
ezio-melotti approved these changes Jan 29, 2025
Contributor
diegorusso commented Jan 29, 2025
Thanks @hugovk. LGTM |
AA-Turner approved these changes Jan 29, 2025
AA-Turner merged commit c67afb5 into python:main 53 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @hugovk for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2025
(cherry picked from commit c67afb5) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-129439 is a backport of this pull request to the 3.13 branch. |
Sorry, @hugovk and @AA-Turner, I could not cleanly backport this to |
AA-Turner pushed a commit that referenced this pull request Jan 29, 2025
hugovk added a commit to hugovk/cpython that referenced this pull request Jan 29, 2025
(cherry picked from commit c67afb5)
GH-129444 is a backport of this pull request to the 3.12 branch. |
AA-Turner pushed a commit that referenced this pull request Jan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arm64 jobs only build, and don't test, but the job name is build and test (arm64):
https://github.com/python/cpython/actions/runs/13029187014/job/36344506016?pr=129426
Until we can add testing, let's update the name to just "build (arm64)":
https://github.com/python/cpython/actions/runs/13030013914/job/36347048011?pr=129434