Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
bpo-36461: Added the total_time parameter to the timeit.autorange() function.#12953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
mangrisano commented Apr 25, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
the-knights-who-say-ni commented Apr 25, 2019
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
ezio-melotti left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments about the tests.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Apr 25, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
mangrisano commented Apr 25, 2019
I've just made the requested changes. Please review. |
tirkarthi commented Apr 26, 2019
There is also another PR that seems to add some additional changes along with the autorange changes in this PR : #12954 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mangrisano commented Apr 26, 2019
I've just read that there's another PR for this issue and it seems to be more complete than mine. What am I suppose to do in this case? |
eamanu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, like say @tirkarthi this PR is related to #12954
and seems more complete that this.
But, this PR is older (one PR older) and receive more feedback.
* Rename the argument from total_time to target_time after Steven's review. * Add some tests to test when number of repeat is 1 or more. * Add target_time parameter in the __init__.
mangrisano commented Jun 2, 2019
I have made the requested changes; please review again. |
bedevere-bot commented Jun 2, 2019
Thanks for making the requested changes! @ezio-melotti: please review the changes made to this pull request. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Jun 3, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
* Delete duplicate test. * Fix indentation.
mangrisano commented Jun 3, 2019
I have made the requested changes; please review again. |
bedevere-bot commented Jun 3, 2019
Thanks for making the requested changes! @ezio-melotti: please review the changes made to this pull request. |
mangrisano commented Jun 3, 2019
I'm trying to figure out how to write a good test for testing the |
* Add the test for autorange with callback. * Add the test for autorange with callback and target_time.
mangrisano commented Jun 3, 2019
I have made the requested changes; please review again. |
bedevere-bot commented Jun 3, 2019
Thanks for making the requested changes! @ezio-melotti: please review the changes made to this pull request. |
mangrisano commented Jun 27, 2019
@stevendaprano Could you review this pull request when you're ready? Thank you :) |
https://bugs.python.org/issue36461