Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
GH-121970: Extract misc_news into a new extension#129577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
AA-Turner commented Feb 2, 2025 • edited by github-actions bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by github-actions bot
Uh oh!
There was an error while loading. Please reload this page.
picnixz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments/questions
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
picnixz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. By the way, for what reason are we changing the "what's new in ...?" text ?
AA-Turner commented Feb 2, 2025
|
picnixz commented Feb 2, 2025
Ah no, I meant: Why is the "What's new in ..." sentences not correct? Namely why are we modifying these parts of the text? |
AA-Turner commented Feb 2, 2025
Blurb outputs "What's New in " before each heading, which we strip for the rendered changelog. Perhaps we should modify Blurb not to do so. |
ae47888 into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, @AA-Turner, I could not cleanly backport this to |
Sorry, @AA-Turner, I could not cleanly backport this to |
GH-129586 is a backport of this pull request to the 3.13 branch. |
…ythonGH-129577) (cherry picked from commit ae47888) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-129587 is a backport of this pull request to the 3.12 branch. |
GH-129587 is a backport of this pull request to the 3.12 branch. |
This removes the
PY_MISC_NEWS_DIRenvironment variable, which was only set/used inmake.bat. I've synchronised it with theMakefile, where we always usebuild/.I considered removing the relative path handling, and changing the file argument of the
.. miscnews::directive to be relative to the Sphinx confdir (i.e. changing to.. miscnews:: build/NEWS), which would somewhat simplify things, but that could be a follow-up.A
pyspecific#121970📚 Documentation preview 📚: https://cpython-previews--129577.org.readthedocs.build/