Skip to content

gh-69001: Replace maintainer email in IDLE credits#129588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terryjreedy merged 2 commits into from
Feb 6, 2025
Merged

gh-69001: Replace maintainer email in IDLE credits #129588

terryjreedy merged 2 commits into from
Feb 6, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Feb 2, 2025•
edited by terryjreedy
Loading

From what I know Terry is the current maintainer and Kurt has not been active for over a decade.

EDIT: Instead, invite PR summarizing contributions.

@bedevere-appbedevere-appbot mentioned this pull request Feb 2, 2025
Open
@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Feb 2, 2025

@terryjreedy

terryjreedy
terryjreedy requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 2013 entry, 'Serwys' should be 'Serwy'.

@bedevere-app
Copy link

bedevere-appbot commented Feb 4, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Change to PRs
79f83dd
Also fix typo in Serwy
@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Feb 5, 2025

I have made the requested changes; please review again

Also modified the typo in the name.

@bedevere-app
Copy link

bedevere-appbot commented Feb 5, 2025

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@terryjreedyterryjreedy self-assigned this Feb 6, 2025
@terryjreedyterryjreedy changed the title gh-69001: Update maintainer email in IDLE creditsgh-69001: Replace maintainer email in IDLE creditsFeb 6, 2025
@terryjreedyterryjreedy added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 6, 2025
@terryjreedyterryjreedy merged commit 76e0182 into python:mainFeb 6, 2025
48 of 52 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented Feb 6, 2025

Thanks @StanFromIreland for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-appbot commented Feb 6, 2025

GH-129713 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2025
@StanFromIreland@miss-islington
pythongh-69001: Replace maintainer email in IDLE credits (pythonGH-12…
a27cfec
…9588) Instead, anyone requesting credit should submit a PR with contribution summary. (Also fix typo in existing name.) (cherry picked from commit 76e0182) Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Feb 6, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2025
@StanFromIreland@miss-islington
pythongh-69001: Replace maintainer email in IDLE credits (pythonGH-12…
2dcbdab
…9588) Instead, anyone requesting credit should submit a PR with contribution summary. (Also fix typo in existing name.) (cherry picked from commit 76e0182) Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented Feb 6, 2025

GH-129714 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Feb 6, 2025
terryjreedy pushed a commit that referenced this pull request Feb 6, 2025
@miss-islington@StanFromIreland
[3.12]gh-69001: Replace maintainer email in IDLE credits (GH-129588) (…
e7fb381
…#129714) Instead, anyone requesting credit should submit a PR with contribution summary. (Also fix typo in existing name.) (cherry picked from commit 76e0182) Co-authored-by: Stan Ulbrych <[email protected]>
terryjreedy pushed a commit that referenced this pull request Feb 6, 2025
@miss-islington@StanFromIreland
[3.13]gh-69001: Replace maintainer email in IDLE credits (GH-129588) (…
825c6e4
…#129713) Instead, anyone requesting credit should submit a PR with contribution summary. (Also fix typo in existing name.) (cherry picked from commit 76e0182) Co-authored-by: Stan Ulbrych <[email protected]>
@StanFromIrelandStanFromIreland deleted the idle-credits branch February 6, 2025 07:44
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@StanFromIreland@srinivasreddy
pythongh-69001: Replace maintainer email in IDLE credits (python#129588)
5d8d0d7
Instead, anyone requesting credit should submit a PR with contribution summary. (Also fix typo in existing name.)
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@StanFromIreland@cmaloney
pythongh-69001: Replace maintainer email in IDLE credits (python#129588)
d4ed8f7
Instead, anyone requesting credit should submit a PR with contribution summary. (Also fix typo in existing name.)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedyterryjreedyterryjreedy approved these changes

Assignees

@terryjreedyterryjreedy

Labels

skip newstopic-IDLE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland@terryjreedy