gh-129701: Fix a data race in intern_common in the free threaded build#130089
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ded build * Use a mutex to avoid potentially returning a non-immortalized string, because immortalization happens after the insertion into the interned dict. * Use `Py_DECREF()` calls instead of `Py_SET_REFCNT(s, Py_REFCNT(s) - 2)` for thread-safety. This code path isn't performance sensistive, so just use `Py_DECREF()` unconditionally for simplicity.
colesbury added skip news 🔨 test-with-refleak-buildbots 
bedevere-bot commented Feb 13, 2025
🤖 New build scheduled with the buildbot fleet by @colesbury for commit a12edba 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot removed the 🔨 test-with-refleak-buildbots 
encukou approved these changes Feb 17, 2025
Member
encukou left a comment
encukou left a comment There was a problem hiding this comment.
LGTM! I didn't check if this solves the issue, but it looks like an improvement.
encukou merged commit b9d2ee6 into python:main 47 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a mutex to avoid potentially returning a non-immortalized string, because immortalization happens after the insertion into the interned dict.
Use
Py_DECREF()calls instead ofPy_SET_REFCNT(s, Py_REFCNT(s) - 2)for thread-safety. This code path isn't performance sensitive, so just usePy_DECREF()unconditionally for simplicity.intern_commonwhen interning str objects in the free threading build #129701