gh-118761: Revert "Improve import time of subprocess (GH-129427)"#130201
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…H-129427)" This reverts commit 49f2465. This caused bugs in the `__del__` finalizer: python#118761 (comment)
gpshead added needs backport to 3.12 
picnixz approved these changes Feb 16, 2025
Misc/NEWS.d/next/Library/2025-02-16-10-12-27.gh-issue-118761.TNw5ZC.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
…Nw5ZC.rst Co-authored-by: Bénédikt Tran <[email protected]>
Member
Actually, shouldn't we remove the previous NEWS entry? I don't know whether it makes sense to have it in the changelog in this case (but if one downloads an exact version they could have it =/) |
MemberAuthor
gpshead commented Feb 16, 2025
This has already shipped in releases. |
MemberAuthor
gpshead commented Feb 16, 2025
So the new NEWS entry is a correction for the previous one. |
gpshead merged commit ae30646 into python:main 39 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
…H-129427)" (pythonGH-130201) * Revert "pythongh-118761: Improve import time of `subprocess` (pythonGH-129427)" This reverts commit 49f2465. Also known as f502c8f in 3.13 (PR pythonGH-129447) Also known as f65aa0d in 3.12 (PR pythonGH-129448) This caused bugs in the `__del__` finalizer: python#118761 (comment) --------- (cherry picked from commit ae30646) Co-authored-by: Gregory P. Smith <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
GH-130204 is a backport of this pull request to the 3.13 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
…H-129427)" (pythonGH-130201) * Revert "pythongh-118761: Improve import time of `subprocess` (pythonGH-129427)" This reverts commit 49f2465. Also known as f502c8f in 3.13 (PR pythonGH-129447) Also known as f65aa0d in 3.12 (PR pythonGH-129448) This caused bugs in the `__del__` finalizer: python#118761 (comment) --------- (cherry picked from commit ae30646) Co-authored-by: Gregory P. Smith <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
GH-130205 is a backport of this pull request to the 3.12 branch. |
gpshead added a commit that referenced this pull request Feb 16, 2025
)" (GH-130201) (#130205) gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" (GH-130201) * Revert "gh-118761: Improve import time of `subprocess` (GH-129427)" This reverts commit 49f2465. Also known as f502c8f in 3.13 (PR GH-129447) Also known as f65aa0d in 3.12 (PR GH-129448) This caused bugs in the `__del__` finalizer: #118761 (comment) --------- (cherry picked from commit ae30646) Co-authored-by: Gregory P. Smith <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
gpshead added a commit that referenced this pull request Feb 16, 2025
)" (GH-130201) (#130204) gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" (GH-130201) * Revert "gh-118761: Improve import time of `subprocess` (GH-129427)" This reverts commit 49f2465. Also known as f502c8f in 3.13 (PR GH-129447) Also known as f65aa0d in 3.12 (PR GH-129448) This caused bugs in the `__del__` finalizer: #118761 (comment) --------- (cherry picked from commit ae30646) Co-authored-by: Gregory P. Smith <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 49f2465.
This caused bugs in the
__del__finalizer:#118761 (comment)