GH-125413: Add private pathlib.Path method to write metadata#130238
Merged
+122 −174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace `WritablePath._copy_writer` with a new `_write_info()` method. This method allows the target of a `copy()` to preserve metadata. Replace `pathlib._os.CopyWriter` and `LocalCopyWriter` classes with new `copy_file()` and `copy_info()` functions. The `copy_file()` function uses `source_path.info` wherever possible to save on `stat()`s.
barneygale changed the title pathlib.Path method to write metadatapathlib.Path method to write metadata17 tasks
barneygale commented Feb 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
barneygale merged commit b251d40 into python:main 39 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
WritablePath._copy_writerwith a new_write_info()method. This method allows the target of acopy()to preserve metadata.Replace
pathlib._os.CopyWriterandLocalCopyWriterclasses with newcopy_file()andcopy_info()functions. Thecopy_file()function usessource_path.infowherever possible to save onstat()s.os.DirEntryobjects from pathlib #125413