gh-130293: Ensure test__colorize will pass on dumb terminals.#130333
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
freakboy3742 commented Feb 20, 2025
!buildbot iOS |
bedevere-bot commented Feb 20, 2025
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 096c689 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130333%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
hugovk approved these changes Feb 20, 2025
Misc/NEWS.d/next/Tests/2025-02-20-13-39-12.gh-issue-130293.5igSsu.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Misc/NEWS.d/next/Tests/2025-02-20-13-39-12.gh-issue-130293.5igSsu.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
freakboy3742 commented Feb 20, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
freakboy3742 merged commit 1b07006 into python:main 39 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2025
…ythonGH-130333) Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> (cherry picked from commit 1b07006) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
GH-130334 is a backport of this pull request to the 3.13 branch. |
freakboy3742 added a commit that referenced this pull request Feb 20, 2025
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
…nals. (pythonGH-130333) (python#130334) Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set) (cherry picked from commit 1b07006) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
…nals. (pythonGH-130333) (python#130334) Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set) (cherry picked from commit 1b07006) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
…als. (pythonGH-130333) (python#130334) Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set) (cherry picked from commit 1b07006) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#129140 slightly modified the logic associated with determining if a console could be colorised. In doing so, the test became sensitive to the test environment's value for the TERM setting.
The iOS 18.2 test simulator sets
TERM=dumbin the test environment - this makes some sense, as stdout/stderr handling is performed by the system log, which won't honor tty control sequences.This appears to be a recent change to iOS; it wasn't true in iOS 17.2. With the recent update to the iOS buildbot, the problem became apparent.
However, the issue isn't iOS specific - it will occur on any machine where
TERM=dumbis set in the testing environment. On macOS, I can reproduce the issue with:This PR ensures that TERM is correctly mocked as part of the colorise test, and normalizes the name used by the iOS Testbed to disable terminal colors.