Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
GH-130396: Use computed stack limits on linux#130398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-130396: Use computed stack limits on linux #130398
Uh oh!
There was an error while loading. Please reload this page.
Conversation
markshannon commented Feb 21, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
ec4cc83 to 6b48afeComparemarkshannon commented Feb 21, 2025
!buildbot .* |
bedevere-bot commented Feb 21, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 12f9ce7 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
brandtbucher left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely not an expert in this particular area, but the changes seem reasonable (provided the buildbots are happy).
Uh oh!
There was an error while loading. Please reload this page.
| * no two calls to check recursion depth are more than this far | ||
| * apart. In practice, that means it must be larger than the C | ||
| * stack consumption of PyEval_EvalDefault */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems sort of fragile? What if there's a ton of unrelated C calls (maybe from a C extension) between two interpreter entries? Does that cause this to be incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any C code that can recurse needs to do checks.
We already do that in plenty of places, like the parser, compiler, json encoding, etc.
C extensions should do it too.
Uh oh!
There was an error while loading. Please reload this page.
markshannon commented Feb 22, 2025
Ignoring prior failures and timesouts, the buildbot fialures are webassembly stack overflows and a couple of odd AIX failures. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Misc/NEWS.d/next/Core_and_Builtins/2025-02-21-11-12-41.gh-issue-130396.SIenSP.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Misc/NEWS.d/next/Core_and_Builtins/2025-02-21-11-12-41.gh-issue-130396.SIenSP.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
markshannon commented Feb 22, 2025
!buildbot was[i|m] |
bedevere-bot commented Feb 22, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit f6002e5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon commented Feb 22, 2025
!buildbot AIX |
bedevere-bot commented Feb 22, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit f6002e5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 415906c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon commented Feb 24, 2025
!buildbot iOS |
bedevere-bot commented Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 415906c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon commented Feb 24, 2025
Compilation failures on both AIX buildbots, but unrelated to this PR. |
markshannon commented Feb 24, 2025
!buildbot wasm |
bedevere-bot commented Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 415906c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon commented Feb 24, 2025
!buildbot iOS |
bedevere-bot commented Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit b3ccffc 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon commented Feb 24, 2025
!buildbot iOS |
bedevere-bot commented Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a2c1656 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon commented Feb 24, 2025
!buildbot wasm |
bedevere-bot commented Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a2c1656 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon commented Feb 24, 2025
!buildbot wasm |
bedevere-bot commented Feb 24, 2025
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a2c1656 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130398%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
0142236 into python:mainUh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Feb 25, 2025
|
bedevere-bot commented Feb 25, 2025
|
Yhg1s commented Mar 26, 2025
FYI, this introduced a new warning in MSVC: so I don't think the attempts to hide the taking of the address of the stack variable work on MSVC. |
Technically, not just linux, but any platform with
pthread_getattr_np.