gh-130419: Do not build the _freeze_module twice in case of Windows PGO builds#130420
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
in case of Windows PGO builds
MemberAuthor
chris-eibl commented Feb 24, 2025
@zooba I think this is an easy one? |
Member
zooba commented Feb 24, 2025
Should be easy, yes, but I'm running a test release to be sure. |
MemberAuthor
chris-eibl commented Feb 24, 2025
Yeah, always good to double check :) |
Member
zooba commented Feb 24, 2025
My extra test was good, so this is okay to merge. GitHub appears to be unhappy about something today though, so my merge isn't going through. If someone else manages to get it to merge, then go ahead! |
zooba merged commit 3a555f0 into python:main 42 checks passed
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Mar 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the Windows PGO build slightly faster by not building the _freeze_module again in the PGUpdate phase.
I think this is a skip-news?
This will also speed up clang-cl PGO build time (#130090).
Using the same idea, all projects with
SupportPGO=Falsecould be built only once (mostly _test modules), but I think this is not worth the effort.