Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commented Feb 22, 2025

@AA-TurnerAA-Turner changed the title GH-121970: Extract pydoc_topics into a new extension (#129116)[3.13] GH-121970: Extract pydoc_topics into a new extension (#129116)Feb 22, 2025
# Conflicts: # Doc/tools/extensions/pyspecific.py
@hugovk
Copy link
Member

Re: #130014 (comment)

Will this also introduce the lint failure during the next release?

@AA-Turner
Copy link
MemberAuthor

Will this also introduce the lint failure during the next release?

I still haven't managed to reproduce the error (note this PR is fine). Local tests with the offending doctest line also seem fine.

@hugovk
Copy link
Member

I can reproduce on main with:

cd Doc make clean venv pydoc-topics cp build/pydoc-topics/topics.py ../Lib/pydoc_data/topics.py

It adds a trailing space on line 5617.

The release process does this, but the regular CI doesn't, so PRs will pass.

@AA-Turner
Copy link
MemberAuthor

AA-Turner commented Feb 22, 2025

This is very odd. I thought it might be my IDE stripping line endings, so I ran the following from a powershell terminal with my IDE closed:

PS> cd Doc PS> python -m sphinx build -M pydoc-topics . build -aETW PS> Move-Item build/pydoc-topics/topics.py ../Lib/pydoc_data/topics.py -Force PS> git commit -am pydoc-topics 

A few changes, but nothing on 5617... I will attempt to try via WSL...

Edit: Same result via WSL...

$ cd Doc $ make clean venv pydoc-topics $ cp build/pydoc-topics/topics.py ../Lib/pydoc_data/topics.py $ git commit -am tmp

@AA-Turner
Copy link
MemberAuthor

#130492 has now been merged, I'll apply the backport labels to it when these PRs are merged.

@AA-TurnerAA-Turner merged commit 93b2bcb into python:3.13Feb 27, 2025
39 checks passed
@AA-TurnerAA-Turner deleted the backport-01bcf13-3.13 branch February 27, 2025 14:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AA-Turner@hugovk