gh-122029: Move monitoring after method expand for CALL_KW#130488
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
markshannon commented Feb 25, 2025
Nice clean fix. Thanks |
markshannon merged commit c5f925c into python:main 63 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in #122029 (comment), we should monitor what really happened for C code. We expanded the possible method first for
CALL, but not forCALL_KW. We should do the same forCALL_KW. We can potentially remove the temp patch in legacy tracing for unpacking methods later.CALL_FUNCTION_EXis another story and to make the PR easy to review, we are dealing withCALL_KWonly in this PR. This should be a very non-intrusive change.