Skip to content

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commented Feb 24, 2025

Copy link
Contributor

@itamaroitamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comment wording suggestions, otherwise looks great, thanks @kumaraditya303 !

kumaraditya303and others added 3 commits March 3, 2025 11:41
Co-authored-by: Itamar Oren <itamarost@gmail.com>
Co-authored-by: Itamar Oren <itamarost@gmail.com>
@kumaraditya303kumaraditya303 enabled auto-merge (squash) March 3, 2025 06:13
@kumaraditya303kumaraditya303 merged commit 7e3b788 into python:mainMar 3, 2025
40 of 41 checks passed
@kumaraditya303kumaraditya303 deleted the eager branch March 3, 2025 06:38
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit 7e3b788.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/10005) and take a look at the build logs.
  4. Check if the failure is related to this commit (7e3b788) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/10005

Failed tests:

  • test.test_concurrent_futures.test_process_pool

Failed subtests:

  • test_force_shutdown_workers - test.test_concurrent_futures.test_process_pool.ProcessPoolForkserverProcessPoolExecutorTest.test_force_shutdown_workers
  • test_force_shutdown_workers - test.test_concurrent_futures.test_process_pool.ProcessPoolSpawnProcessPoolExecutorTest.test_force_shutdown_workers

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_importlib/metadata/fixtures.py", line 391, in _inner func(self, **args) ~~~~^^^^^^^^^^^^^^ File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_concurrent_futures/test_process_pool.py", line 279, in test_force_shutdown_workersself.assertEqual(worker_process.exitcode, -signal.SIGTERM) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 255 != -15 Traceback (most recent call last): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_importlib/metadata/fixtures.py", line 391, in _inner func(self, **args) ~~~~^^^^^^^^^^^^^^ File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_concurrent_futures/test_process_pool.py", line 281, in test_force_shutdown_workersself.assertEqual(worker_process.exitcode, -signal.SIGKILL) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 255 != -9

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303@bedevere-bot@itamaro