Revert "GH-116380: Speed up glob.[i]glob() by making fewer system calls. (#116392)"#130743
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…stem calls. (python#116392)" This broke tests on the 'aarch64 Fedora Stable Clang Installed 3.x' and 'AMD64 Fedora Stable Clang Installed 3.x' build bots. This reverts commit da4899b.
barneygale changed the title glob.[i]glob() by making fewer system calls. (#116392)glob.[i]glob() by making fewer system calls. (#116392)"
picnixz approved these changes Mar 1, 2025
Member
picnixz left a comment
picnixz left a comment There was a problem hiding this comment.
If this a simple application of git revert the I think I can approve it without looking at it too long right?
ContributorAuthor
barneygale commented Mar 1, 2025
Indeed, it's a |
Member
picnixz commented Mar 1, 2025
In this case (and in the future), I think you don't need my approval then :) (it would be too hard to actually check that the revert is correct using the web UI) |
barneygale merged commit 5326c27 into python:main 48 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke tests on the 'aarch64 Fedora Stable Clang Installed 3.x' and 'AMD64 Fedora Stable Clang Installed 3.x' build bots.
This reverts commit da4899b.
glob.glob()by reducing number of system calls made #116380📚 Documentation preview 📚: https://cpython-previews--130743.org.readthedocs.build/