Skip to content

Conversation

@donbarbos
Copy link
Contributor

@donbarbosdonbarbos commented Mar 10, 2025

I'm also going to send a similar PR for the pickle module (for same flags)

And I'm not sure if I should send a separate PR or I can add it here

@donbarbosdonbarbos changed the title Remove -t and -v flags from pickletools cligh-93096: Remove -t and -v flags from pickletools cliMar 10, 2025
@donbarbos
Copy link
ContributorAuthor

I also made sure that unit tests call doctests, we add them here:

defload_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite(pickletools))
returntests

cc @serhiy-storchaka

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that these options are not documented at: https://docs.python.org/dev/library/pickletools.html#command-line-usage

@serhiy-storchaka: Are you ok with removing these undocumented pickletools CLI options?

@donbarbos
Copy link
ContributorAuthor

He commented this changes here: #130973 (comment)

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinnervstinner merged commit 3ddf983 into python:mainMar 11, 2025
45 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@donbarbos@vstinner@serhiy-storchaka