Skip to content

Conversation

@donbarbos
Copy link
Contributor

@donbarbosdonbarbos commented Mar 11, 2025

  • added load doctest to unittest
  • we still can run doctests using: ./python -m doctest Lib/pickle.py -v


def load_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite())
tests.addTest(doctest.DocTestSuite(pickle))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this looks like a bugfix. It should be backported. Can you extract this change into a new PR? It's not directly related to CLI changes.

Copy link
ContributorAuthor

@donbarbosdonbarbosMar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure, should i open new issue or can i send PR for the current issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reuse the same issue.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to document the current command line interface (CLI) in Doc/library/pickle.rst? https://docs.python.org/dev/library/pickle.html

@donbarbos
Copy link
ContributorAuthor

Would it be possible to document the current command line interface (CLI) in Doc/library/pickle.rst? https://docs.python.org/dev/library/pickle.html

I think it can be suggested in issue #130160

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka: Are you ok with these changes?

@vstinner
Copy link
Member

I think it can be suggested in issue #130160

You can reuse #93096 or create a new issue.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinnervstinner merged commit 425e0af into python:mainMar 11, 2025
43 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@donbarbos@vstinner@serhiy-storchaka