gh-131032: Add support.linked_to_musl() function#131071
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Skip test_math.test_fma_zero_result() if Python is linked to the musl C library.
vstinner added skip news needs backport to 3.12 
MemberAuthor
vstinner commented Mar 11, 2025
Member
skirpichev commented Mar 11, 2025
Looks fine. Is this reported to upstream (I can't find a bugreport)? |
MemberAuthor
vstinner commented Mar 11, 2025
Last year I reported a similar issue to FreeBSD: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277783 |
MemberAuthor
vstinner commented Mar 11, 2025
I sent an email to https://www.openwall.com/lists/musl/ but my email is currently waiting for moderators (I suppose), it's not online yet. |
MemberAuthor
vstinner commented Mar 11, 2025
My bug report: https://www.openwall.com/lists/musl/2025/03/11/1 |
skirpichev approved these changes Mar 11, 2025
Member
skirpichev left a comment
skirpichev left a comment There was a problem hiding this comment.
LGTM
Is there some buildbot to trigger this "skipIf" (except for WASI)?
On another hand, maybe it's a good idea to add a workaround for handling zero arguments (like we have _Py_log1p(), I not sure it's still relevant).
MemberAuthor
vstinner commented Mar 12, 2025
I proposed a different fix for test_math: #131134 |
vstinner merged commit 68922ac into python:main 46 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, @vstinner, I could not cleanly backport this to |
Sorry, @vstinner, I could not cleanly backport this to |
GH-131179 is a backport of this pull request to the 3.13 branch. |
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 13, 2025
Skip test_math.test_fma_zero_result() if Python is linked to the musl C library. (cherry picked from commit 68922ac)
MemberAuthor
vstinner commented Mar 13, 2025
Oops, math.fma() was added to Python 3.13. |
vstinner added a commit that referenced this pull request Mar 13, 2025
bitdancer added a commit to bitdancer/cpython that referenced this pull request Mar 15, 2025
A relatively small number of tests fail when the underlying c library is provided by musl. This was originally reported in bpo-46390 by Christian Heimes. Among other changes, these tests were marked for skipping in pythongh-31947/ef1327e3 as part of bpo-40280 (emscripten support), but the skips were conditioned on the *platform* being emscripten (or wasi, skips for which ere added in 9b50585). In pythongh-131071 Victor Stinner added a linked_to_musl function to enable skipping a test in test_math that fails under musl, like it does on a number of other platforms. This check can successfully detect that python is running under musl on Alpine, which was the original problem report in bpo-46390. This PR replaces Victor's solution with an enhancement to platform.libc_ver that does the check more cheaply, and also gets the version number. The latter is important because the math test being skipped is due to a bug in musl that has been fixed, but as of this checkin date has not yet been released. When it is, the test skip can be fixed to check for the minimum needed version. The enhanced version of linked_to_musl is also used to do the skips of the other tests that generically fail under musl, as opposed to emscripten or wasi only failures. This will allow these tests to be skipped automatically on Alpine. This PR does *not* enhance libc_ver to support emscripten and wasi, as I'm not familiar with those platforms; instead it returns a version triple of (0, 0, 0) for those platforms. This means the musl tests will be skipped regardless of musl version, so ideally someone will add support to libc_ver for these platforms.
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
Skip test_math.test_fma_zero_result() if Python is linked to the musl C library.
bitdancer added a commit that referenced this pull request Mar 19, 2025
* Make musl test skips smarter (fixes Alpine errors) A relatively small number of tests fail when the underlying c library is provided by musl. This was originally reported in bpo-46390 by Christian Heimes. Among other changes, these tests were marked for skipping in gh-31947/ef1327e3 as part of bpo-40280 (emscripten support), but the skips were conditioned on the *platform* being emscripten (or wasi, skips for which ere added in 9b50585). In gh-131071 Victor Stinner added a linked_to_musl function to enable skipping a test in test_math that fails under musl, like it does on a number of other platforms. This check can successfully detect that python is running under musl on Alpine, which was the original problem report in bpo-46390. This PR replaces Victor's solution with an enhancement to platform.libc_ver that does the check more cheaply, and also gets the version number. The latter is important because the math test being skipped is due to a bug in musl that has been fixed, but as of this checkin date has not yet been released. When it is, the test skip can be fixed to check for the minimum needed version. The enhanced version of linked_to_musl is also used to do the skips of the other tests that generically fail under musl, as opposed to emscripten or wasi only failures. This will allow these tests to be skipped automatically on Alpine. This PR does *not* enhance libc_ver to support emscripten and wasi, as I'm not familiar with those platforms; instead it returns a version triple of (0, 0, 0) for those platforms. This means the musl tests will be skipped regardless of musl version, so ideally someone will add support to libc_ver for these platforms. * Platform tests and bug fixes. In adding tests for the new platform code I found a bug in the old code: if a valid version is passed for version and it is greater than the version found for an so *and* there is no glibc version, then the version from the argument was returned. The code changes here fix that. * Add support docs, including for some preexisting is_xxx's. * Add news item about libc_ver enhancement. * Prettify platform re expression using re.VERBOSE.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip test_math.test_fma_zero_result() if Python is linked to the musl C library.