gh-93096: Load doctests in test_itertools#131133
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
27 tasks
ContributorAuthor
donbarbos commented Mar 12, 2025
I found |
vstinner added needs backport to 3.12 
Member
vstinner commented Mar 12, 2025
I modified the doctest with the change below, ran diff --git a/Modules/itertoolsmodule.c b/Modules/itertoolsmodule.c index 3e425ee5f92..092316cf255 100644 --- a/Modules/itertoolsmodule.c+++ b/Modules/itertoolsmodule.c@@ -124,7 +124,7 @@ or when the input iterable is exhausted. >>> for batch in batched('ABCDEFG', 3): ... print(batch) ... - ('A', 'B', 'C')+ ('Aa', 'B', 'C') ('D', 'E', 'F') ('G',) |
vstinner merged commit 15a8412 into python:main 52 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @donbarbos for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 12, 2025
(cherry picked from commit 15a8412) Co-authored-by: donBarbos <donbarbos@proton.me>
GH-131136 is a backport of this pull request to the 3.13 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 12, 2025
(cherry picked from commit 15a8412) Co-authored-by: donBarbos <donbarbos@proton.me>
GH-131137 is a backport of this pull request to the 3.12 branch. |
vstinner pushed a commit that referenced this pull request Mar 12, 2025
vstinner pushed a commit that referenced this pull request Mar 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have one doctest in
Modules/itertoolsmodule.cand none intest_itertolls.pyso this is definitely a bug like issue #131069