Skip to content

Conversation

@donbarbos
Copy link
Contributor

@donbarbosdonbarbos commented Mar 12, 2025

@donbarbos
Copy link
ContributorAuthor

cc @vstinner
:-)

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @hugovk

@rhettinger
Copy link
Contributor

This isn't a performance test. It is used by module maintainers to view generated distributions to see if they match the expected distributions.

@rhettingerrhettinger requested a review from tim-oneMarch 12, 2025 17:21
@donbarbos
Copy link
ContributorAuthor

I think it would be right to get rid of the --test flags in modules with cli.
This flag is not documented and is not displayed in the --help output.

And it seems author of this flag is not against removing it

@rhettinger
Copy link
Contributor

I'm going to decline this. It isn't part of the public API so there is no user benefit to removing it. I do use this when maintaining the module so it does have some value. And the test code has nothing to do with pyperformance so this PR would be moving the code from where a mainainer can find it to a place where it clearly doesn't make sense.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@donbarbos@rhettinger@vstinner