gh-131152: Remove unused imports from tests (part 2)#131154
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vstinner requested review from FFY00, ambv, barneygale, brettcannon, ericsnowcurrently, ethanfurman, jaraco, lysnikolaou, ncoghlan, pablogsal, rhettinger and warsaw as code owners
pablogsal approved these changes Mar 12, 2025
rhettinger approved these changes Mar 12, 2025
vstinner merged commit b2ca268 into python:main 46 checks passed
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
vstinner commented Mar 13, 2025
Merged, thanks for reviews. |
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
jaraco reviewed May 12, 2025
| importpickle | ||
| importstat | ||
| importsys | ||
| importtime |
Member
There was a problem hiding this comment.
This change will get overwritten unless it's ported to zipp. I'm slightly surprised that there are unused imports, given that I run ruff over the codebase. Oh, I see now. gh-123424 has not yet been backported to zipp, and that's where time was used. So shouldn't be a problem getting this synced once that one is.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.