GH-131296: fix clang-cl warnings in sysmodule.c#131304
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chris-eibl commented Mar 15, 2025
| #ifdefMS_WINDOWS | ||
| staticPyTypeObjectWindowsVersionType={0, 0, 0, 0, 0, 0}; | ||
| staticPyTypeObjectWindowsVersionType={0}; |
MemberAuthor
There was a problem hiding this comment.
Previously, this generated 3 times
warning : suggest braces around initialization of subobject [-Wmissing-braces] Doubled/or trippled, because compiled in the _freeze_module, too.
chris-eibl commented Mar 17, 2025
| } | ||
| #ifndefMS_WINDOWS |
MemberAuthor
There was a problem hiding this comment.
fix warning : unused variable 'perf_map_state' [-Wunused-variable]
Member
There was a problem hiding this comment.
This one was fixed by 486d537, you can now revert the change which just removes an empty line, no?
MemberAuthor
chris-eibl commented Mar 20, 2025
Rebased, because #131487 partly touched it |
vstinner merged commit a2ea417 into python:main 47 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.