bpo-36165 Fix rst formatting for several links in ssl documentation#13133
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* The formatting for ssl.PROTOCOL_SSLv23 and ssl.SSLContext.wrap_bio was missing a colon so they weren't properly formatted as links. * Corrected link SSLContext.wrap_socket() to be singular instead of plural Fixes https://bugs.python.org/issue36165
ContributorAuthor
abadger commented May 7, 2019
Thanks @lisroach ! |
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 7, 2019
* master: (1204 commits) bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (pythonGH-11521) Forbid creating of stream objects outside of asyncio (python#13101) bpo-35925: Skip SSL tests that fail due to weak external certs. (pythonGH-13124) Fix rst formatting for several links in ssl documentation (pythonGH-13133) bpo-36542: Allow to overwrite the signature for Python functions. (pythonGH-12705) bpo-36793: Remove unneeded __str__ definitions. (pythonGH-13081) bpo-36766: Typos in docs and code comments (pythonGH-13116) bpo-36275: enhance documentation for venv.create() (pythonGH-13114) Clarify the download unit in the download section (pythonGH-13122) bpo-30668: add missing word in license.rst (pythonGH-13115) Unroll import-team in CODEOWNERS (python#13118) bpo-36594: Fix incorrect use of %p in format strings (pythonGH-12769) bpo-36798: Updating f-string docs for := use case (pythonGH-13107) Update wsgiref.rst (python#10488) Doc/c-api/exceptions.rst: fix grammar (python#12091) bpo-36811: Fix a C compiler warning in _elementtree.c. (pythonGH-13109) Only count number of members once (python#12691) bpo-16024: Doc cleanup regarding path_fd, dir_fd, follow_symlinks (pythonGH-5505) bpo-36791: Safer detection of integer overflow in sum(). (pythonGH-13080) bpo-33530: Implement Happy Eyeballs in asyncio, v2 (pythonGH-7237) ...
Contributor
miss-islington commented Jun 21, 2019
Contributor
miss-islington commented Jun 21, 2019
Contributor
miss-islington commented Jun 21, 2019
Sorry, @abadger and @lisroach, I could not cleanly backport this to |
bedevere-bot commented Jun 21, 2019
GH-14281 is a backport of this pull request to the 3.7 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2019
Contributor
miss-islington commented Jun 21, 2019
Contributor
miss-islington commented Jun 21, 2019
Sorry @abadger and @lisroach, I had trouble checking out the |
miss-islington added a commit that referenced this pull request Jun 21, 2019
(cherry picked from commit 7b3a028) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
abadger added a commit to abadger/cpython that referenced this pull request Jun 24, 2019
…onGH-13133). (cherry picked from commit 7b3a028) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatting for ssl.PROTOCOL_SSLv23 and ssl.SSLContext.wrap_bio was
missing a colon so they weren't properly formatted as links.
Corrected link SSLContext.wrap_socket() to be singular instead of plural
Fixes https://bugs.python.org/issue36165
https://bugs.python.org/issue36165