Skip to content

GH-131238: More refactoring of core header files#131351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 6 commits into from
Mar 17, 2025
Merged

GH-131238: More refactoring of core header files #131351

markshannon merged 6 commits into from
Mar 17, 2025

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Mar 17, 2025•
edited by bedevere-app bot
Loading

Breaks a few more dependencies between header files and adds a lot of more fine grained includes to .c files.

@bedevere-appbedevere-appbot mentioned this pull request Mar 17, 2025
Closed
@markshannonmarkshannon mentioned this pull request Mar 17, 2025
Merged
@markshannonmarkshannon marked this pull request as ready for review March 17, 2025 13:42
@markshannonmarkshannon merged commit a45f253 into python:mainMar 17, 2025
69 checks passed
@markshannonmarkshannon deleted the core-header-refactor-2 branch March 17, 2025 17:23
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@markshannon@plashchynski
pythonGH-131238: More refactoring of core header files (pythonGH-131351)
6b86c9d
Adds new pycore_stats.h header file to help break dependencies involving the pycore_code.h header.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

@ethanfurmanethanfurmanAwaiting requested review from ethanfurman

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@isidenticalisidenticalAwaiting requested review from isidentical

@Eclips4Eclips4Awaiting requested review from Eclips4

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-SpinnerFidget-Spinner is a code owner

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

@carljmcarljmAwaiting requested review from carljmcarljm is a code owner

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markshannon@iritkatriel