Skip to content

Conversation

@mhsmith
Copy link
Member

@mhsmithmhsmith commented Mar 18, 2025

The hanging buildbot in #124666 was caused by a leftover thread created in the test's setUp method. It was supposed to be cleaned up by tearDown, but that isn't called automatically when setUp fails.

I still don't know why the underlying test failure was happening, but I've increased all the timeouts to LOOPBACK_TIMEOUT (10 seconds) in case that makes a difference.

Also cleaned up a couple of other test failure logging issues.

@mhsmith
Copy link
MemberAuthor

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 4997d1b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131427%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable set of fixes to me. If nothing else, I guess this means the failure case will actually fail, rather than timing out, which is a definite improvement; maybe the new failure will reveal more detail about why it's failing? (We can but hope :-) )

@freakboy3742freakboy3742 merged commit 01b5abb into python:mainMar 18, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2025
) Ensures that failures in test setup don't result in dangling threads. (cherry picked from commit 01b5abb) Co-authored-by: Malcolm Smith <smith@chaquo.com>
@bedevere-app
Copy link

GH-131433 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Mar 18, 2025
freakboy3742 pushed a commit that referenced this pull request Mar 19, 2025
…131433) Ensures that failures in test setup don't result in dangling threads. (cherry picked from commit 01b5abb) Co-authored-by: Malcolm Smith <smith@chaquo.com>
colesbury pushed a commit to colesbury/cpython that referenced this pull request Mar 20, 2025
Ensures that failures in test setup don't result in dangling threads.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent buildbot failure and timeout on Android aarch64

3 participants

@mhsmith@bedevere-bot@freakboy3742