Skip to content

gh-127833: lexical analysis: Improve section on Names#131474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 5 commits into from
May 21, 2025
Merged

gh-127833: lexical analysis: Improve section on Names #131474

encukou merged 5 commits into from
May 21, 2025

Conversation

@encukou
Copy link
Member

@encukouencukou commented Mar 19, 2025•
edited by github-actions bot
Loading

Use consistent terminology: "names" are "identifiers", "keywords", and "soft keywords".
Start with the simple case (ASCII), then get more and more technical.
Define NAME in the formal lexical grammar.
Exclude keywords in the identifier definition.

📚 Documentation preview 📚: https://cpython-previews--131474.org.readthedocs.build/

@encukouencukou added docs Documentation in the Doc dir skip news labels Mar 19, 2025
StanFromIreland
StanFromIreland reviewed Mar 19, 2025
View reviewed changes
@encukou@StanFromIreland
Update Doc/reference/lexical_analysis.rst
4f33459
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-appbedevere-appbot mentioned this pull request Mar 20, 2025
Open
@encukouencukou added the needs backport to 3.14 bugs and security fixes label May 7, 2025
@terryjreedy
Copy link
Member

terryjreedy commented May 11, 2025

I like the re-arrangement and separation of identifier and keyword.

@encukou
Copy link
MemberAuthor

encukou commented May 16, 2025

Thanks for the reviews!
I plan to merge on Wednesday if there are no objections.

@encukouencukou merged commit c7364f7 into python:mainMay 21, 2025
41 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsMay 21, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented May 21, 2025

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@encukouencukou deleted the lex-analysis-names branch May 21, 2025 14:01
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@encukou@StanFromIreland
@blaisep@miss-islington
pythongh-127833: lexical analysis: Improve section on Names (pythonGH…
e87ea00
…-131474) (cherry picked from commit c7364f7) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Blaise Pabon <blaise@gmail.com>
@bedevere-app
Copy link

bedevere-appbot commented May 21, 2025

GH-134423 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented May 21, 2025

Sorry @encukou, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.14" label.
Please backport backport using cherry_picker on the command line.

cherry_picker c7364f79b2fb01c251e22115875a46a2ec134dcd 3.14

hugovk pushed a commit that referenced this pull request May 26, 2025
@miss-islington@encukou
@StanFromIreland@blaisep
[3.14]gh-127833: lexical analysis: Improve section on Names (GH-131474…
ebfd18b
…) (#134423) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Blaise Pabon <blaise@gmail.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@encukou@StanFromIreland
@blaisep@lkollar
pythongh-127833: lexical analysis: Improve section on Names (pythonGH…
5b0571c
…-131474) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Blaise Pabon <blaise@gmail.com>
@encukouencukou mentioned this pull request Jun 18, 2025
Open
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou@StanFromIreland
@blaisep@Pranjal095
pythongh-127833: lexical analysis: Improve section on Names (pythonGH…
4abf176
…-131474) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Blaise Pabon <blaise@gmail.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou@StanFromIreland
@blaisep@taegyunkim
pythongh-127833: lexical analysis: Improve section on Names (pythonGH…
9c75a60
…-131474) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Blaise Pabon <blaise@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

@encukouencukou

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou@terryjreedy@StanFromIreland