Skip to content

GH-131296: fix clang-cl warning on Windows in pegen.h#131584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Apr 15, 2025
Merged

GH-131296: fix clang-cl warning on Windows in pegen.h #131584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Parser/pegen.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,7 @@ void *_PyPegen_raise_error_known_location(Parser *p, PyObject *errtype,
void _Pypegen_set_syntax_error(Parser* p, Token* last_token);
void _Pypegen_stack_overflow(Parser *p);

Py_LOCAL_INLINE(void *)
static inline void *
Copy link
MemberAuthor

@chris-eiblchris-eiblMar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpython/Include/pyport.h

Lines 190 to 197 in 18249d9

#if defined(_MSC_VER)
/* ignore warnings if the compiler decides not to inline a function */
# pragma warning(disable: 4710)
/* fastest possible local call under MSVC */
# definePy_LOCAL(type) static type __fastcall
# definePy_LOCAL_INLINE(type) static __inline type __fastcall
#else
# definePy_LOCAL(type) static type

__fastcall is anyway only in effect for 32bit builds. The warning stems from the _freeze_module, which is by default compiled in 32bit mode (unless you override PreferredToolArchitecture). Let's simply convert to static inline.

RAISE_ERROR_KNOWN_LOCATION(Parser *p, PyObject *errtype,
Py_ssize_t lineno, Py_ssize_t col_offset,
Py_ssize_t end_lineno, Py_ssize_t end_col_offset,
Expand Down
Loading