Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-119180: Use equality when comparing against annotationlib.Format#131755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Viicos commented Mar 26, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
| forbaseinreversed(obj.__mro__): | ||
| ann=annotationlib.get_annotations(base, format=format) | ||
| ifformatisannotationlib.Format.STRING: | ||
| ifformat==annotationlib.Format.STRING: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add at least one test case affected by this? Would require passing Format.STRING.value to get_type_hints().
JelleZijlstra commented Mar 27, 2025
Your tests are failing |
af2afd7 into python:mainUh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Mar 28, 2025
|
As per #119180 (comment).
We can probably skip news on this one.