GH-130415: Remove redundant sym_matches_type calls in the JIT optimizer#131778
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
brandtbucher added skip news interpreter-core 
17 tasks
Fidget-Spinner approved these changes Mar 27, 2025
Member
Fidget-Spinner left a comment
Fidget-Spinner left a comment There was a problem hiding this comment.
I think this should be fine. After all the uops only occur after a guard.
brandtbucher merged commit 972a295 into python:main 69 checks passed
Uh oh!
There was an error while loading. Please reload this page.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should already be narrowed by a previous guard. If we made a mistake somewhere, the
asserts inside the body of theifwill catch it.