GH-131296: fix clang-cl warning on Windows in liblzma#131897
Uh oh!
There was an error while loading. Please reload this page.
Conversation
| <AdditionalIncludeDirectories>$(lzmaDir)windows/vs2019;$(lzmaDir)src/liblzma/common;$(lzmaDir)src/common;$(lzmaDir)src/liblzma/api;$(lzmaDir)src/liblzma/check;$(lzmaDir)src/liblzma/delta;$(lzmaDir)src/liblzma/lz;$(lzmaDir)src/liblzma/lzma;$(lzmaDir)src/liblzma/rangecoder;$(lzmaDir)src/liblzma/simple;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | ||
| <DisableSpecificWarnings>4028;4113;4133;4244;4267;4996;%(DisableSpecificWarnings)</DisableSpecificWarnings> | ||
| <DisableSpecificWarnings>4244;4267;4996;%(DisableSpecificWarnings)</DisableSpecificWarnings> | ||
| <AdditionalOptionsCondition="$(PlatformToolset) == 'ClangCL'">%(AdditionalOptions) -Wno-deprecated-declarations</AdditionalOptions> |
There was a problem hiding this comment.
This disables the warning
tuklib_physmem.c(82,7): warning : 'GetVersion' is deprecated [-Wdeprecated-declarations] in https://github.com/python/cpython/actions/runs/14136067992/job/39607990169#step:4:168.
| <PreprocessorDefinitions>WIN32;HAVE_CONFIG_H;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions> | ||
| <AdditionalIncludeDirectories>$(lzmaDir)windows/vs2019;$(lzmaDir)src/liblzma/common;$(lzmaDir)src/common;$(lzmaDir)src/liblzma/api;$(lzmaDir)src/liblzma/check;$(lzmaDir)src/liblzma/delta;$(lzmaDir)src/liblzma/lz;$(lzmaDir)src/liblzma/lzma;$(lzmaDir)src/liblzma/rangecoder;$(lzmaDir)src/liblzma/simple;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | ||
| <DisableSpecificWarnings>4028;4113;4133;4244;4267;4996;%(DisableSpecificWarnings)</DisableSpecificWarnings> | ||
| <DisableSpecificWarnings>4244;4267;4996;%(DisableSpecificWarnings)</DisableSpecificWarnings> |
There was a problem hiding this comment.
Warnings 4028, 4113 and 4133 are no longer emitted. Tested for ARM, ARM64, Win32 and x64 in Debug and Release configuration for MSVC and clang-cl (except ARM).
Warning 4996 is the deprecation warning, that clang-cl unfortunately does not understand in DisableSpecificWarnings.
chris-eibl commented Mar 30, 2025
@zooba Since this only touches a vcxproj, most probably you are a suitable reviewer? OOI, since the devguide is not clear on this (or I didn't find it): may I ask on my own for a review? Or shall I wait until someone is assigned? |
picnixz changed the title 
zooba commented Mar 31, 2025
Yeah, I can take this one. Thanks for checking that the MSVC warnings are cleaned up too, I figured they would be, just hadn't gotten to checking them. |
zooba merged commit cf839c3 into python:mainUh oh!
There was an error while loading. Please reload this page.
3 participants
I think this is a skip news?