gh-131895: fix $PATH for clang on Darwin runners for tail-calling interpreter#131903
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
picnixzforce-pushed the infra/fix/tail-calling-interpreter-darwin-clang-131895 branch from 24deed1 to 012e38aCompare This comment was marked as resolved.
This comment was marked as resolved.
picnixzforce-pushed the infra/fix/tail-calling-interpreter-darwin-clang-131895 branch from f215493 to e9e9d29CompareMemberAuthor
picnixz commented Mar 30, 2025
Ok... I forgot the |
MemberAuthor
picnixz commented Mar 30, 2025
It works \o/ |
chris-eibl approved these changes Mar 30, 2025
Member
chris-eibl left a comment
chris-eibl left a comment There was a problem hiding this comment.
LGTM!
So easy once you see the diff but sometimes less easy to get there :)
MemberAuthor
picnixz commented Mar 30, 2025
Yes. It's always a challenge to review YML code and code where glyphs are hard to distinguish sometimes (like, |
Fidget-Spinner approved these changes Mar 30, 2025
picnixz merged commit 39fa19a into python:main 44 checks passed
Uh oh!
There was an error while loading. Please reload this page.
picnixz deleted the infra/fix/tail-calling-interpreter-darwin-clang-131895 branch Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configurefailures on x86_64/aarch64 apple-darwin/clang #131895