gh-105499: typing: Remove an unused function#131946
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Leftover from python#105511 I believe. GitHub code search found no usages other than copies of typing.py and lists of stdlib functions.
Member
AlexWaygood commented Mar 31, 2025
there's now only one usage of |
MemberAuthor
JelleZijlstra commented Mar 31, 2025
Good point, done |
AlexWaygood approved these changes Mar 31, 2025
MemberAuthor
JelleZijlstra commented Mar 31, 2025
Also noticed some unused imports, so removed those too |
Member
Maybe you should update the title, e.g., |
JelleZijlstra changed the title JelleZijlstra merged commit 0f511d8 into python:main 38 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftover from #105511 I believe. GitHub code search found no usages other
than copies of typing.py and lists of stdlib functions.