Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commented Apr 3, 2025

This PR achieves a 27x improvement in import time for the string module. The main improvement comes from replacing Template.__init_subclass__() (GH-16256) with a descriptor class, allowing lazy import of the re module.

Current:

import string: cumulative time mean: 9162.100 µs median: 9133.000 µs stdev: 66.662 min: 9071 max: 9301 

This PR:

import string: cumulative time mean: 334.967 µs median: 329.000 µs stdev: 13.438 min: 316 max: 368 

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy with this because I need to access many times string.* constants without needing the Template class so it's a very good optimization.

@python-cla-bot
Copy link

All commit authors signed the Contributor License Agreement.

CLA signed

@AA-TurnerAA-Turner requested a review from picnixzApril 6, 2025 17:56
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea. The code looks intimidating, but it might work.

How the help output looks now?

Is __init_subclass__() needed anymore?

@AA-Turner
Copy link
MemberAuthor

Help output looks fine:

>>> from string import Template >>> assert Template.flags isNone >>> help(Template) Help on class Template in module string: class Template(builtins.object) | Template(template) | | A string class for supporting $-substitutions. | | Methods defined here: | | __init__(self, template) | Initialize self. See help(type(self)) for accurate signature. | | get_identifiers(self) | | is_valid(self) | | safe_substitute(self, mapping={}, /, **kws) | | substitute(self, mapping={}, /, **kws) | | ---------------------------------------------------------------------- | Class methods defined here: | | __init_subclass__() | This method is called when a class is subclassed. | | The default implementation does nothing. It may be | overridden to extend subclasses. | | ---------------------------------------------------------------------- | Data descriptors defined here: | | __dict__ | dictionary for instance variables | | __weakref__ | list of weak references to the object | | ---------------------------------------------------------------------- | Data and other attributes defined here: | | braceidpattern = None | | delimiter = '$' | | flags = re.IGNORECASE | | idpattern = '(?a:[_a-z][_a-z0-9]*)' | | pattern = re.compile('\n \\$(?:\n ...identifie... >>> 

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It perhaps could be made simpler with classmethod + property, but the future of this feature is not clear.

Co-authored-by: Serhiy Storchaka <[email protected]>
@AA-TurnerAA-Turner enabled auto-merge (squash) April 8, 2025 09:44
@AA-TurnerAA-Turner merged commit ee36572 into python:mainApr 8, 2025
39 checks passed
@AA-TurnerAA-Turner deleted the opt-string branch April 8, 2025 10:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performancePerformance or resource usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AA-Turner@serhiy-storchaka@picnixz