enum: remove unused function#132044
Merged
enum: remove unused function #132044
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
All commit authors signed the Contributor License Agreement. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hugovk approved these changes Apr 7, 2025
Member
hugovk left a comment
hugovk left a comment There was a problem hiding this comment.
History: _dedent was added in #30582 (then briefly reverted in #30632 and re-added in #30637) in v3.11.0a5.
Then its use was removed in #94188 in v3.12.0a1 but the function not removed.
I think it's safe to remove the function: it wasn't documented, was underscore prefixed, is very similar to textwrap.dedent() which should be the first choice, and I don't find any use of _dedent on GitHub code search.
AA-Turner approved these changes Apr 7, 2025
methane merged commit e2b35ee into python:main 48 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_dedentin enum was added in this PR.https://github.com/python/cpython/pull/30582/files#diff-e5dd6e444e4e6c2cdeb8edf271d057f9da52f7b406dcd8b655dc396fb013bd03
But it is not used now.