Skip to content

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Apr 4, 2025

This is the final preparatory PR for top-of-stack caching

This PR:

  • Removes the stack manipulation macros. Instructions must declare values as dead, and let the code generator pop them from the stack
  • Updates the instrumented instructions to be explicit about their stack effect
  • Supports mixing of scalars and arrays on the stack. The code generator pushes scalars to memory if needed for an array.

@markshannon
Copy link
MemberAuthor

markshannon commented Apr 4, 2025

The MSVC tail calling interpreter failure seems unrelated to this PR.

@markshannonmarkshannon merged commit 7099c75 into python:mainApr 4, 2025
70 of 71 checks passed
@markshannonmarkshannon deleted the code-gen-handle-stacks branch April 4, 2025 17:09
picnixz pushed a commit to picnixz/cpython that referenced this pull request Apr 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon@iritkatriel@StanFromIreland@hpagvn87