Skip to content

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented Apr 8, 2025

@picnixz

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@picnixz

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@picnixzpicnixz requested a review from hugovkApril 8, 2025 11:58
@picnixz
Copy link
MemberAuthor

On iOS, mocking didn't seem to work correctly (and I don't know why) so we'll just make something even more unknown. If bar_ext is a registered extension, then I think the system is really weird.

@picnixz
Copy link
MemberAuthor

And I forgot to print the help correctly...

@picnixz

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@picnixz
Copy link
MemberAuthor

Hum. Interestingly, on main python -m mimetypes actually exits before printing the help. So technically... it's not even needed:

$ python -m mimetypes usage: python -m mimetypes [-h] [-e] [-l] type [type ...] python -m mimetypes: error: the following arguments are required: type 

The (incorrect) return parser.format_help() is not even reached because _parse_args() is already raising SystemExit (this is because the argument is required!)

@picnixz
Copy link
MemberAuthor

picnixz commented Apr 8, 2025

Great, the test suite now passes on iOS (still running):

0:08:04 load avg: 31.35 [278/486] test_mimetypes 0:08:04 load avg: 44.62 [278/486] test_mimetypes passed 

@picnixz

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@picnixzpicnixz merged commit f5a7037 into python:mainApr 8, 2025
42 of 44 checks passed
@picnixzpicnixz deleted the fix/tests/mimetypes-ios-arm-93096 branch April 8, 2025 13:03
@johnzhou721
Copy link
Contributor

FWIW: Same behavior reproducible on macOS Sonoma on Alpha 1, but it's now resovled..

johnzhou721 pushed a commit to johnzhou721/cpython that referenced this pull request May 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz@bedevere-bot@johnzhou721