gh-131507: Add a way to recreate the Misc/mypy symlinks if missing#132274
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
They will be removed in source tarballs so they don't appear in the SBOM.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
ContributorAuthor
ambv commented Apr 8, 2025
(I undid the mistaken force-push, but there's no log entry about that happening.) |
pablogsal approved these changes Apr 8, 2025
ambv merged commit 16dcb57 into python:main 94 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 8, 2025
…ssing (pythonGH-132274) They will be removed in source tarballs so they don't appear in the SBOM. (cherry picked from commit 16dcb57) Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
GH-132293 is a backport of this pull request to the 3.13 branch. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They will be removed in source tarballs so they don't appear in the SBOM.
This is an alternative to #132270 that keeps the symlinks in the repository. This has the following advantages:
.gitignorefile;mypy.iniconfiguration files that add theMisc/mypydirectory can be used in a local type-checking workflow without running any additional tools.This allows running type checking without building Python first or running the additional script manually. This is important because the type-checking errors emitted due to missing symlinks are confusing and don't suggest what the solution is.
The only disadvantage of this PR compared to #132270 is that we still keep symlinks in the repository 🤷🏻♂️