Skip to content

gh-118761: Add helper to ensure that lazy imports are actually lazy#132614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 2 commits into from
Apr 17, 2025
Merged

gh-118761: Add helper to ensure that lazy imports are actually lazy #132614

JelleZijlstra merged 2 commits into from
Apr 17, 2025

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented Apr 16, 2025•
edited by bedevere-app bot
Loading

This ensures that if we jump through some hoops to make sure something is imported
lazily, we don't regress on importing it.

I recently already accidentally made typing import warnings and annotationlib eagerly.

@JelleZijlstra
pythongh-118761: Add helper to ensure that lazy imports are actually …
a55b37e
…lazy This ensures that if we jump through some hoops to make sure something is imported lazily, we don't regress on importing it. I recently already accidentally made typing import warnings and annotationlib eagerly.
@bedevere-appbedevere-appbot mentioned this pull request Apr 16, 2025
Closed
JelleZijlstra
JelleZijlstra commented Apr 16, 2025
View reviewed changes
Lib/test/test_typing.py
"inspect",
"re",
"contextlib",
# "annotationlib", # TODO
Copy link
MemberAuthor

@JelleZijlstraJelleZijlstraApr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#132596 will fix this

AA-Turner
AA-Turner approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@JelleZijlstraJelleZijlstra enabled auto-merge (squash) April 17, 2025 03:24
@JelleZijlstraJelleZijlstra merged commit 39ee468 into python:mainApr 17, 2025
38 checks passed
@danielhollasdanielhollas mentioned this pull request Apr 27, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JelleZijlstra@AA-Turner