Skip to content

gh-131591: Reset RemoteDebuggerSuupport state after fork#132793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 4 commits into from
Apr 25, 2025
Merged

gh-131591: Reset RemoteDebuggerSuupport state after fork #132793

pablogsal merged 4 commits into from
Apr 25, 2025

Conversation

@Zheaoli
Copy link
Contributor

@ZheaoliZheaoli commented Apr 22, 2025•
edited by bedevere-app bot
Loading

FYI I think we need to reset process _PyRemoteDebuggerSupport state after os.fork. Otherwise, the child process may inherit the pendding_call == 1 state

@bedevere-appbedevere-appbot mentioned this pull request Apr 22, 2025
Closed
@Zheaoli
Copy link
ContributorAuthor

Zheaoli commented Apr 24, 2025•
edited
Loading

@pablogsal PTAL when you got time

pablogsal
pablogsal reviewed Apr 24, 2025
View reviewed changes
@pablogsal
Copy link
Member

pablogsal commented Apr 24, 2025

@godlygeek WDYT?

Zheaoliand others added 3 commits April 24, 2025 20:27
@Zheaoli@pablogsal
Update Misc/NEWS.d/next/Core_and_Builtins/2025-04-22-19-00-03.gh-issu…
4b7b1d3
…e-131591.CdEqBr.rst Co-authored-by: Pablo Galindo Salgado <[email protected]>
@Zheaoli@pablogsal
Update Modules/posixmodule.c
ba09801
Co-authored-by: Pablo Galindo Salgado <[email protected]>
@Zheaoli
fix review idea
16f3f24
Signed-off-by: Manjusaka <[email protected]>
@ZheaoliZheaoliforce-pushed the manjusaka/reset-fork-remote branch from 8288a7e to 16f3f24CompareApril 24, 2025 12:31
@ZheaoliZheaoli requested a review from pablogsalApril 24, 2025 15:27
@godlygeek
Copy link
Contributor

godlygeek commented Apr 24, 2025

FYI I think we need to reset process _PyRemoteDebuggerSupport state after os.fork.

I agree, good catch!

@pablogsalpablogsal merged commit 3a39e33 into python:mainApr 25, 2025
46 checks passed
@pablogsal
Copy link
Member

pablogsal commented Apr 25, 2025

Thanks a lot for your contribution @Zheaoli !

@ZheaoliZheaoli deleted the manjusaka/reset-fork-remote branch April 25, 2025 07:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zheaoli@pablogsal@godlygeek