Skip to content

gh-132908: Add math.isnormal/issubnormal() functions#132935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 10 commits into from
Jun 2, 2025
Merged

gh-132908: Add math.isnormal/issubnormal() functions #132935

serhiy-storchaka merged 10 commits into from
Jun 2, 2025

Conversation

@skirpichev
Copy link
Member

@skirpichevskirpichev commented Apr 25, 2025•
edited by github-actions bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Apr 25, 2025
Closed
StanFromIreland
StanFromIreland reviewed Apr 25, 2025
View reviewed changes
skirpichev
skirpichev commented Apr 25, 2025
View reviewed changes
skirpichev
skirpichev commented Apr 25, 2025
View reviewed changes
@skirpichev@StanFromIreland
Apply suggestions from code review
4eb3669
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
picnixz
picnixz approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cosmetic nits.

skirpichevand others added 2 commits April 25, 2025 17:45
@skirpichev@picnixz
Apply suggestions from code review
37b3345
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@skirpichev@picnixz
Apply suggestions from code review
e318087
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

picnixz commented Apr 25, 2025

So, we have some known buildbots issues. I'll wait for it to be solved and then once it's ok for them, I'll merge it.

@skirpichev
Copy link
MemberAuthor

skirpichev commented Apr 25, 2025

Technically it's very trivial pr, yet I would appreciate a second look from someone.

Maybe we should be more vague and not define in any way normal/subnormal meaning (i.e. not reference sys.float_info). (Or mention this as CPython implementation detail.) E.g. should all Python implementations support subnormals?

StanFromIreland
StanFromIreland approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the docs and implementation are fine, everything is explained well.

skirpichev
skirpichev commented Apr 28, 2025
View reviewed changes
Copy link
MemberAuthor

@skirpichevskirpichev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can replace "floating-point number" with just a "number" (as integers are automatically converted to floats)?

@skirpichev
Copy link
MemberAuthor

skirpichev commented Jun 2, 2025

CC @serhiy-storchaka per experts index. See also issue thread.

@serhiy-storchakaserhiy-storchaka changed the title gh-132908: add math.normal/subnormal() functionsgh-132908: Add math.isnormal/issubnormal() functionsJun 2, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchakaserhiy-storchaka merged commit 5f61cde into python:mainJun 2, 2025
39 checks passed
@skirpichevskirpichev deleted the isnormal-subnormal/132908 branch June 2, 2025 10:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev@picnixz@serhiy-storchaka@StanFromIreland