Skip to content

bpo-23378: Add an extend action to argparse#13305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 2 commits into from
May 21, 2019
Merged

bpo-23378: Add an extend action to argparse #13305

miss-islington merged 2 commits into from
May 21, 2019

Conversation

@isidentical
Copy link
Member

@isidenticalisidentical commented May 14, 2019•
edited by bedevere-bot
Loading

Add an extend action to argparse

https://bugs.python.org/issue23378

asottile
asottile reviewed May 18, 2019
View reviewed changes
Copy link
Contributor

@asottileasottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch looks good, are there other nargs=... that this makes sense with? should it produce an error in the nonsensical cases? should it default to nargs='+'?

@isidentical
Copy link
MemberAuthor

isidentical commented May 18, 2019

nargs=N doesn't make any sense (it doesn't need extend but extend can be used like append). but i dont think we should produce a ValueError etc.

furkanonder
furkanonder approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@furkanonderfurkanonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

gvanrossum
gvanrossum reviewed May 20, 2019
View reviewed changes
gvanrossum
gvanrossum approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@miss-islington
Copy link
Contributor

miss-islington commented May 21, 2019

@isidentical: Status check is done, and it's a success ✅ .

@miss-islingtonmiss-islington merged commit aa32a7e into python:masterMay 21, 2019
@isidenticalisidentical deleted the issue23378 branch December 7, 2019 12:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@furkanonderfurkanonderfurkanonder approved these changes

+1 more reviewer

@asottileasottileasottile left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@isidentical@miss-islington@asottile@gvanrossum@furkanonder@the-knights-who-say-ni@bedevere-bot