[3.13] gh-133122: Fix for test_type_lookup_mro_reference.#133127
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Change the unit test case to use `getattr()` so that we avoid the bytecode specializer optimizing the access. The specializer will call the `__eq__` method before the unit test expects, causing it to fail. In the 3.14 branch (pythongh-128164) the test is changed in a different way to avoid the same issue.
naschemeforce-pushed the gh-132942-tp-mro-no-specialize branch from f56453a to 36a74b9Comparenascheme merged commit 64dcbb0 into python:3.13 36 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the unit test case to use
getattr()so that we avoid the bytecode specializer optimizing the access. The specializer will call the__eq__method before the unit test expects, causing it to fail.In the 3.14 branch (gh-128164) the test is changed in a different way to avoid the same issue.