gh-97907: use cancellation error from child if possible#133243
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
At present when cancelling the result of an :func:`asncio.gather` call, the last child is used to create the cancellation error. If that was not cancelled but another child was, its cancellation message and traceback will be lost. Fix this by using the cancellation error from the first of the children to be cancelled, if any, falling back to the last child only if none have been.
duaneg requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present when cancelling the result of an :func:
asncio.gathercall, the last child is used to create the cancellation error. If that was not cancelled but another child was, its cancellation message and traceback will be lost.Fix this by using the cancellation error from the first of the children to be cancelled, if any, falling back to the last child only if none have been.