gh-133351: Fix Cmd completion for lines beginning with ! #133362
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When a line begins with `!` and there's no `do_shell` method defined, `parsecmd` returns `None` as the `cmd`, which incorrectly leads to `None` being concatenated to `complete_` and triggering a `TypeError`. Instead, recognize `None` as a sentinel that means we should call `completedefault`, as an empty string already is.
ContributorAuthor
godlygeek commented May 4, 2025
Actually, let me close this and open a new issue for it, since this probably deserves a real news entry unrelated to PDB... |
Member
gaogaotiantian commented May 4, 2025
You can just change the gh issue number. |
ContributorAuthor
godlygeek commented May 4, 2025
Too late, I wasn't sure so I opened #133364 😓 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a line begins with
!and there's nodo_shellmethod defined,parsecmdreturnsNoneas thecmd, which incorrectly leads toNonebeing concatenated tocomplete_and triggering aTypeError.Instead, recognize
Noneas a sentinel that means we should callcompletedefault, as an empty string already is.